Skip to content

Add support for order="K" or "A" for dpnp.empty_like, dpnp.ones_like, dpnp.zeros_like and dpnp.full_like #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 7, 2024
Merged

Add support for order="K" or "A" for dpnp.empty_like, dpnp.ones_like, dpnp.zeros_like and dpnp.full_like #2088

merged 7 commits into from
Oct 7, 2024

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Oct 5, 2024 •
edited
Loading

In this PR, support for order="K" and order="A" is added to for dpnp.empty_like, dpnp.ones_like, dpnp.zeros_like and dpnp.full_like.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Oct 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 5, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana force-pushed the update_order_for_create_like_func branch from ae7cabd to e0baee1 Compare October 5, 2024 01:46
@vtavana vtavana marked this pull request as ready for review October 5, 2024 04:02
antonwolfy
antonwolfy reviewed Oct 7, 2024
View reviewed changes
antonwolfy
antonwolfy approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @vtavana

@vtavana vtavana merged commit 48515c8 into master Oct 7, 2024
42 checks passed
@vtavana vtavana deleted the update_order_for_create_like_func branch October 7, 2024 21:11
github-actions bot added a commit that referenced this pull request Oct 7, 2024
@github-actions
Add support for order="K" or "A" for dpnp.empty_like, `dpnp.one…
d9f4b62 
…s_like`, `dpnp.zeros_like` and `dpnp.full_like` (#2088)

* update order

* use flag.c_contiguous

* address comments

* raise ValueError with correct msg when an invalid order is given

* fix a bug when order is None 48515c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vtavana @antonwolfy